Code changes
Code changes
Just wondering (to the authors) whether you're amenable to (non-functional) changes to the code base such as adding comments to the ROM code (or even functional changes if it can be improved). I thought I'd have a look-see but soon realised that the actual commentary within many files is non-existent.
Code changes
The functional changes are always being tweaked. It's why we're on ROM version 41. As far as comments go, Michael probably started with copious comments but he's been over it so much by now he could probably recite any given KERNAL or BASIC function's code from memory.
Code changes
On 5/23/2022 at 12:21 AM, paxdiablo said:
Just wondering (to the authors) whether you're amenable to (non-functional) changes to the code base such as adding comments to the ROM code (or even functional changes if it can be improved). I thought I'd have a look-see but soon realised that the actual commentary within many files is non-existent.
The decision is ultimately up to @Michael Steil. He's an approachable and reasonable person though, so if your changes correctly document the code and focus on documenting functions that need it (as opposed to every single line that is sometimes seen in assembly code), I think they would have a good chance of getting merged. Michael's favorite response anytime anybody suggests fixing something in the ROM is: "Pull request?"
